-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClimateMachine example documentation #32
Conversation
Hi Igacio, thanks for this! Comments as I see them:
In general - Could you add a section about the Bayesian problem. Just what the ingredients are for this - (1) what is the dynamic model (doesn't have to be too specific), but be very specific about (2) what the data we are using, and (3) what the priors are. Do you have a paper / references for this model too - which could be something easy to point people towards Looking great thank you Ignacio! |
Thanks for the input! I have followed most of your suggestions in this new version. Unfortunately, there is no good reference for the problem, but I have added some more information about the output, and the solution. |
A couple more comments:
Otherwise looks great thanks Ignacio! |
Regarding the last point: In this simple example I am taking as data a single 30-min average horizontal velocity profile after initialization. Therefore, this is not in a statistically stationary regime. The problem is basically deterministic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - As Zhaoyi is a new user, I shall also let her add feedback if she sees possible improvements before merge
bors r+ |
Merge conflict. |
bors r+ |
Build succeeded: |
No description provided.