Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensemble tranform Kalman inversion #329

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

eviatarbach
Copy link
Contributor

@eviatarbach eviatarbach commented Oct 1, 2023

I somehow made some mistake with the branches and closed the last PR, #320, and couldn't reopen it. This should be ready to merge. Closes #324.

Scaling test timings

For Julia v1 tests outputs:

ETKI with 10 observations took 0.013366613000000005 seconds.
ETKI with 100 observations took 0.026825424999999983 seconds.
ETKI with 1000 observations took 0.17781986400000005 seconds.
ETKI with 10000 observations took 1.249208766 seconds.

@eviatarbach eviatarbach force-pushed the square-root branch 2 times, most recently from 7c779a0 to 9301478 Compare October 1, 2023 14:31
@odunbar
Copy link
Collaborator

odunbar commented Oct 2, 2023

LGTM! Please merge, I'm happy to bypass that specific codecov warning.

For future reference, I added the timings from the ubuntu runtests.jl into the PR message

@eviatarbach
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 15fad65 into CliMA:main Oct 2, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement and test ensemble transform Kalman inversion (ETKI)
2 participants