Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for accelerators #336

Merged
merged 18 commits into from
Nov 15, 2023
Merged

Add examples for accelerators #336

merged 18 commits into from
Nov 15, 2023

Conversation

sydneyvernon
Copy link
Contributor

@sydneyvernon sydneyvernon commented Oct 18, 2023 •
edited by odunbar
Loading

Purpose

To-do

Content

  • I have read and checked the items on the review checklist.

@sydneyvernon
Copy link
Contributor Author

We see acceleration in both of these examples (Darcy and Exp Sin)--still working on writing them up in a readable way.

@odunbar
Copy link
Collaborator

odunbar commented Oct 24, 2023

@sydneyvernon Any movement on adding the Localizers example in here?

@odunbar
Copy link
Collaborator

odunbar commented Nov 7, 2023 •
edited
Loading

Please include closed environments for the projects
i.e., add Project.tomls to each example directory.

odunbar
odunbar reviewed Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment, and please check all examples run with both options of USE_SCHEDULER

examples/Accelerators/ExpSinAccelerated/exp_sinusoid_accelerated.jl Outdated Show resolved Hide resolved
@odunbar odunbar changed the title Add examples and docs for accelerators Add examples for accelerators Nov 13, 2023
odunbar
odunbar approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

LGTM!

@odunbar odunbar merged commit 3ae43fb into CliMA:main Nov 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odunbar odunbar odunbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Example for some nonlinear problems
2 participants
@sydneyvernon @odunbar