Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constrained_gaussian TOML parser #353

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add constrained_gaussian TOML parser #353

merged 1 commit into from
Nov 13, 2023

Conversation

nefrathenrici
Copy link
Member

A few notes:

  • The test for this parser directly compares to a Parameterized(Normal()) distribution rather than the constrained_gaussian constructor
  • If the distribution being parsed is a constrained gaussian, the constraint constructor is bypassed

@nefrathenrici nefrathenrici linked an issue Nov 9, 2023 that may be closed by this pull request
Add parser for constrained_gaussian from TOML #314
Closed
@nefrathenrici nefrathenrici force-pushed the ne/constr_gauss_parser branch 4 times, most recently from 924e4f9 to 3b4f57d Compare November 11, 2023 00:06
odunbar
odunbar reviewed Nov 11, 2023
View reviewed changes
src/TOMLInterface.jl Outdated Show resolved Hide resolved
odunbar
odunbar approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after

  • you address the small comment, and
  • you add a test_throws argument for the wrong repeats type?

src/TOMLInterface.jl Outdated Show resolved Hide resolved
@nefrathenrici nefrathenrici merged commit 9224c1b into main Nov 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odunbar odunbar odunbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add parser for constrained_gaussian from TOML
2 participants
@nefrathenrici @odunbar