Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix logpdf broadcasting #364

Merged
merged 6 commits into from
Jan 24, 2024
Merged

bugfix logpdf broadcasting #364

merged 6 commits into from
Jan 24, 2024

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jan 24, 2024 •
edited
Loading

Purpose

Content

  • Removes accidental broadcast of logpdf (which causes errors when applying logpdf to multivariate julia-Distributions types)
  • Specifies behavior for Parameterized distributions on x <: Real and x <: AbstractVector, to be compatible with Julia Distributions (e.g. Distributions does not like logpdf(Normal(0,1), [0.0]) but we allow it)
  • adds tests
  • I have read and checked the items on the review checklist.

eviatarbach
eviatarbach approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@eviatarbach eviatarbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odunbar odunbar merged commit 3428c95 into main Jan 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviatarbach eviatarbach eviatarbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove broadcasting for Logpdf.
2 participants
@odunbar @eviatarbach