Add save_parameter_samples
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefrathenrici
force-pushed
the
ne/extend_save_params
branch
from
ed605e2
to
d6d2374
Compare
odunbar
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Hi @nefrathenrici
Just a couple of small points to address then merge away
LGTM!
src/TOMLInterface.jl
Outdated
| default_param_data::Dict, | ||
| save_path, | ||
| save_file; | ||
| pad_zeros = 3, |
There was a problem hiding this comment.
Is there a reason we hard-code this to 3?
There was a problem hiding this comment.
No, I set it to be an optional keyword argument.
src/TOMLInterface.jl
Outdated
| - rng - The random number generator used in sampling | ||
| """ | ||
| function save_parameter_samples( | ||
| distribution::ParameterDistribution{Samples}, |
There was a problem hiding this comment.
This function would work with any distribution right? It doesn't need to be a Samples-type?
Unless there is a reason to restrict to this, we could allow others
There was a problem hiding this comment.
As long as sample is defined for the given distribution, it would work. I will remove the type constraint!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function
save_parameter_sampleswhich takes samples from the given Samples distribution and saves them to individual TOML files for use in model runs.