Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin Distributions version #56

Merged
merged 1 commit into from
Sep 30, 2021
Merged

unpin Distributions version #56

merged 1 commit into from
Sep 30, 2021

Conversation

costachris
Copy link
Member

The Distributions package pinned previously was incompatible with the new TC.jl environment.

@haakon-e
Copy link
Member

Is there any reason this package should be pinned, @odunbar?

@odunbar
Copy link
Collaborator

odunbar commented Sep 28, 2021

I believe we required some kind of compat for the version release. So I would rather you didn't delete it outright.
What would be more useful, is if you can expand the allowable range in compat to be compatible with TC.

Could run the unit tests offline to make sure there aren't issues too with the compatible version of Distributions at the edge of the new range? (as I'm not sure if the online tests will use the same version)

@costachris
Copy link
Member Author

@odunbar Okay I used a range instead, which fixes our problem. All tests in test/runtests.jl pass locally.

@ilopezgp
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 30, 2021

Build succeeded:

@bors bors bot merged commit 21eef62 into main Sep 30, 2021
@bors bors bot deleted the update_dependencies branch September 30, 2021 21:37
@navidcy navidcy mentioned this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants