Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create GitHub action that cleans up the Docs preview versions from PRs #66

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Create GitHub action that cleans up the Docs preview versions from PRs #66

merged 2 commits into from
Oct 11, 2021

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Oct 10, 2021

@navidcy navidcy requested a review from odunbar October 10, 2021 07:09
@charleskawczynski
Copy link
Member

The GHA in https://github.com/CliMA/TimeMachine.jl/blob/master/.github/workflows/DocCleanup.yml seems to look a bit different. In particular, the if [ -d "previews/PR$PRNUM" ]; then in TimeMachine.jl seems like this happens conditionally, which doesn't seem to be the case in this PR. Is this an updated recommended version from somewhere?

@navidcy
Copy link
Contributor Author

navidcy commented Oct 11, 2021

The GHA in https://github.com/CliMA/TimeMachine.jl/blob/master/.github/workflows/DocCleanup.yml seems to look a bit different. In particular, the if [ -d "previews/PR$PRNUM" ]; then in TimeMachine.jl seems like this happens conditionally, which doesn't seem to be the case in this PR. Is this an updated recommended version from somewhere?

I got this from Documenter.jl Docs --> https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#gh-pages-Branch

@navidcy
Copy link
Contributor Author

navidcy commented Oct 11, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 11, 2021

Build succeeded:

@bors bors bot merged commit d267509 into main Oct 11, 2021
@bors bors bot deleted the ncc/docs-previews-cleanup branch October 11, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski approved these changes

@odunbar odunbar Awaiting requested review from odunbar

Assignees
No one assigned
Labels
package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navidcy @charleskawczynski