-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add implementation of sparse EKI #70
Conversation
Hi Jinlong, the way we have been adding different methods is by keeping them separated rather than using flags. As the sparsity preserving EKI is sufficiently different from EKI maybe we could do it in this case. (You can use the Could you create a new file
We can call to chat more about this |
Note I got this to run by first
and then in the project base
then in the example directory
|
Is there a way to implement the Sparse EKI without |
I have updated the implementation to avoid |
I forgot to mention the unit tests. Your code is untested Could you transfer the sparse example you created, and place it in the file inside you then add some To checkthe testing offline you go to the base and do
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent addition. LGTM
Please add a check for the L^1 norm in the sparse eki loop.
If you could create a docs PR soon, that adds a page linking to your paper / what the sparsity means in this context etc. that would be awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After my Threads.@threads
question has been addressed by someone more experienced with Julia, LGTM.
bors r+ |
Build succeeded: |
This PR adds the option of sparse EKI to Ensemble Kalman Inversion process:
EnsembleKalmanInversion.jl
LossMinimization/loss_minimization_sparse_eki.jl
)