-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified EKI/EKS runtest #73
Conversation
@agarbuno @jinlong83 could I get some reviews on this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made few suggestions for plotting style
Thanks Navid! See new plots |
I guess we can't really compare the two algorithms at a specific simulated time
So if
Maybe try with a sufficiently large number of ensemble updates? Since this is a linear and Gaussian setting it shouldn't take so long and from the figures I guess it has been sufficient for both methods to stabilize in their respective long-time behavior. I believe we should proceed to merge this. |
Thanks! In the previous implementation, different realizations, steps and ensemble sizes caused tests to fail. I think that this test gives more separation between the OLS and posterior mean. and more reliable results. We can discuss offline about the algorithmic time implication of how comparable the progression of the algorithms are. |
bors r+ |
Build succeeded: |
Purpose
To get the EKI runtest properly working with a linear map from R^{2} -> R^{10}. (i) some reason a couple of the
@test
statements were commented out (ii) the tests comparing EKS and EKI are very dependent on N_iterIn the PR
Changes to the EKI test in
test/EnsembleKalmanInversion/runtests.jl
So that it now converges reasonably and satisfies all the test conditions.NB some of the comparisons of eks/eki depended heavily on
N_iter
. To compare the two algorithms we should really look at the timesteps in absolute time. So noweksobj
The OLS mean is nearer the EKI at the end time, and the posterior mean is nearer the EKS at the end time, far more robustly than previously.
Test output plot
For EKI
For EKS