Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udpdate module names to new convention. #93

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Udpdate module names to new convention. #93

merged 1 commit into from
Jan 22, 2022

Conversation

ilopezgp
Copy link
Contributor

@ilopezgp ilopezgp commented Jan 19, 2022

Updates module names to follow the convention of module having the same name as the file where it is stored.

Also eliminates the EnsembleKalmanProcess module and structures the EnsembleKalmanProcess tests.

@ilopezgp ilopezgp force-pushed the naming_conventions branch 2 times, most recently from 31b8f5f to 26bd5cd Compare January 20, 2022 05:06
@ilopezgp ilopezgp requested a review from odunbar January 20, 2022 05:13
@odunbar
Copy link
Collaborator

odunbar commented Jan 20, 2022

So to summarize we changed some modules. So that a module ObjectNames contains a struct ObjectName

  • Removed EnsembleKalmanProcessModule completely, now only refer to the parent module EnsembleKalmanProcesses.
  • Renamed ParameterDistributionStorageto ParameterDistributions.

Did you also want to change the following?

  • DataStorage to DataContainers (as module creates the DataContainer struct)
  • Obs to Observation (as it is contained in the module Observations)
    (This would require filename changes too)

@ilopezgp
Copy link
Contributor Author

Good suggestions, I will do that as well.

@ilopezgp
Copy link
Contributor Author

ilopezgp commented Jan 20, 2022

Should be good to go now @odunbar !

@odunbar
Copy link
Collaborator

odunbar commented Jan 22, 2022

LGTM! @ilopezgp merge when ready

@ilopezgp
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 22, 2022

Build succeeded:

@bors bors bot merged commit 9d5f4ab into main Jan 22, 2022
@bors bors bot deleted the naming_conventions branch January 22, 2022 01:12
@ilopezgp ilopezgp linked an issue Jan 23, 2022 that may be closed by this pull request
@ilopezgp
Copy link
Contributor Author

ilopezgp commented Jan 23, 2022

Closed #6 .

@ilopezgp ilopezgp linked an issue Jan 23, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module and module file names are inconsistent
2 participants