-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Udpdate module names to new convention. #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilopezgp
force-pushed
the
naming_conventions
branch
2 times, most recently
from
January 20, 2022 05:06
31b8f5f
to
26bd5cd
Compare
So to summarize we changed some modules. So that a module
Did you also want to change the following?
|
Good suggestions, I will do that as well. |
ilopezgp
force-pushed
the
naming_conventions
branch
from
January 20, 2022 21:14
fa351e2
to
95a6d92
Compare
Should be good to go now @odunbar ! |
LGTM! @ilopezgp merge when ready |
odunbar
approved these changes
Jan 22, 2022
bors r+ |
Build succeeded: |
Closed #6 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates module names to follow the convention of module having the same name as the file where it is stored.
Also eliminates the EnsembleKalmanProcess module and structures the EnsembleKalmanProcess tests.