Skip to content

Commit

Permalink
Remove misleading comment (#3493)
Browse files Browse the repository at this point in the history
* bugfix

* remove comment
  • Loading branch information
simone-silvestri committed Mar 5, 2024
1 parent d7911ab commit 66c0889
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
9 changes: 0 additions & 9 deletions src/Fields/field.jl
Original file line number Diff line number Diff line change
Expand Up @@ -743,15 +743,6 @@ end
function fill_halo_regions!(field::Field, args...; kwargs...)
reduced_dims = reduced_dimensions(field)

# To correctly fill the halo regions of fields with non-default indices, we'd have to
# offset indices in the fill halo regions kernels.
# For now we punt and don't support filling halo regions on windowed fields.
# Note that `FieldBoundaryConditions` _can_ filter boundary conditions in
# windowed directions:
#
# filtered_bcs = FieldBoundaryConditions(field.indices, field.boundary_conditions)
#
# which will be useful for implementing halo filling for windowed fields in the future.
fill_halo_regions!(field.data,
field.boundary_conditions,
field.indices,
Expand Down
2 changes: 1 addition & 1 deletion test/test_distributed_hydrostatic_model.jl
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Ny = 32
for arch in archs
@testset "Testing distributed solid body rotation" begin
grid = LatitudeLongitudeGrid(arch, size = (Nx, Ny, 1),
halo = (3, 3, 3),
halo = (4, 4, 4),
latitude = (-80, 80),
longitude = (-160, 160),
z = (-1, 0),
Expand Down

0 comments on commit 66c0889

Please sign in to comment.