Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpointer fails if boundary condition is a CuArray #420

Closed
suyashbire1 opened this issue Sep 18, 2019 · 2 comments
Closed

Checkpointer fails if boundary condition is a CuArray #420

suyashbire1 opened this issue Sep 18, 2019 · 2 comments
Labels
bug 🐞 Even a perfect program still has bugs GPU 👾 Where Oceananigans gets its powers from output 💾

Comments

@suyashbire1
Copy link
Collaborator 

ERROR: LoadError: cannot write a pointer to JLD file
@suyashbire1 suyashbire1 added bug 🐞 Even a perfect program still has bugs GPU 👾 Where Oceananigans gets its powers from labels Sep 18, 2019
@glwagner
Copy link
Member

Hmm... we'd have to convert this to an array, and then convert back for this to work automatically.

A simple fix to start could just be to avoid saving boundary conditions when they contain references to an array.

Is it possible to use has_reference(CuArray, boundary_conditions)?

@ali-ramadhan ali-ramadhan mentioned this issue Feb 16, 2020
Merged
@ali-ramadhan
Copy link
Member

Closing as the Checkpointer no longer serializes boundary conditions as of PR #1082 so this shouldn't happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Even a perfect program still has bugs GPU 👾 Where Oceananigans gets its powers from output 💾
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suyashbire1 @glwagner @ali-ramadhan