-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New checkpointer features: set! and simulation "pickup" #1082
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
+ Coverage 56.79% 57.16% +0.36%
==========================================
Files 161 161
Lines 3796 3838 +42
==========================================
+ Hits 2156 2194 +38
- Misses 1640 1644 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super neat! Should make checkpointing and pickup so much smoother and less prone to expensive mistakes.
@@ -1,3 +1,6 @@ | |||
using Glob | |||
import Oceananigans.Fields: set! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Co-authored-by: Ali Ramadhan <[email protected]>
Co-authored-by: Ali Ramadhan <[email protected]>
This PR adds two new features for interacting with
Checkpointer
s.The first is the method
that sets all the checkpointed data in
checkpointer_filepath
tomodel
, including tendencies, and synchronizes the model clock and iteration with the checkpointed clock and iteration.The second is a kwarg in
run!
meant to be used as eitheror
or
where
n
is an integer that refers to an iteration number of a checkpointer file to be "picked up" and run from, andfilepath
is a string that indicates the path to checkpoint data.pickup=true
looks for the latest checkpointed file and picks up the simulation from there.To do:
set!
run!
JLD2OutputWriter
so it doesn't fail in common use casesResolves #1068
Resolves #602