-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should Model
be renamed to IncompressibleModel
or BoussinesqModel
?
#566
Comments
Are we anticipating having more than one model? There’s a few possible designs. For example, we could abstract the “equation”, rather than the model. |
If we have Compressible than Incompressible makes sense. But if we have QGModel, then Boussinesq makes more sense. Our choice depends on the models available. |
I would say incompressible. Essential assumption is divv=0. We can have a
non-Boussinesq incompressible model by going in to pressure coordinates.
This would be one version of a family of incompressible models. Ali also
has an incompressible version. So to me a compressible/incompressible
naming fork makes sense.
…On Thu, Dec 12, 2019, 9:25 AM Gregory L. Wagner ***@***.***> wrote:
If we have Compressible than Incompressible makes sense. But if we have
QGModel, then Boussinesq makes more sense. Our choice depends on the models
available.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#566>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKXUEQRYWL2UJ3KNBCOZYADQYJCVPANCNFSM4JZ6UGIA>
.
|
I think @johncmarshall54's stance is sensible. It's more likely we will have non-Boussinesq and compressible models than a QGModel. |
Sorry for the slow reply. Indeed I was thinking of introducing a |
I guess
BoussinesqModel
is a subset ofIncompressibleModel
? MaybeBoussinesqModel
is only true if you're running with tracers. If you're running with zero tracers then there's no buoyancy per se.The text was updated successfully, but these errors were encountered: