Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should get rid of the BoundaryConditions alias #582

Closed
ali-ramadhan opened this issue Dec 20, 2019 · 0 comments · Fixed by #583
Closed

We should get rid of the BoundaryConditions alias #582

ali-ramadhan opened this issue Dec 20, 2019 · 0 comments · Fixed by #583
Labels
bug 🐞 Even a perfect program still has bugs

Comments

@ali-ramadhan
Copy link
Member

Could lead to confusion, e.g. in #579. Thanks for helping locate this issue @masonrogers14.

Easy PR but might involve refactoring some tests?

https://github.com/climate-machine/Oceananigans.jl/blob/588890004e69cfc7db10472b12a9840b8a9ad7b6/src/boundary_conditions.jl#L339
@ali-ramadhan ali-ramadhan added the bug 🐞 Even a perfect program still has bugs label Dec 20, 2019
@ali-ramadhan ali-ramadhan mentioned this issue Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Even a perfect program still has bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove BoundaryConditions alias CliMA/Oceananigans.jl
1 participant
@ali-ramadhan