Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BoundaryConditions alias #583

Merged
merged 2 commits into from
Dec 21, 2019
Merged

Remove BoundaryConditions alias #583

merged 2 commits into from
Dec 21, 2019

Conversation

ali-ramadhan
Copy link
Member

Resolves #582

@ali-ramadhan ali-ramadhan added the bug 🐞 Even a perfect program still has bugs label Dec 20, 2019
Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably avoid aliases in the future too.

@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #583 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #583   +/-   ##
=======================================
  Coverage   72.17%   72.17%           
=======================================
  Files          70       70           
  Lines        2016     2016           
=======================================
  Hits         1455     1455           
  Misses        561      561
Impacted Files Coverage Δ
src/boundary_conditions.jl 61.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5888900...4b06fb3. Read the comment docs.

@ali-ramadhan ali-ramadhan merged commit cc24eda into master Dec 21, 2019
@ali-ramadhan ali-ramadhan deleted the ar/fix-issue-582 branch December 21, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Even a perfect program still has bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should get rid of the BoundaryConditions alias
2 participants