Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the code the "normal" way #598

Closed
jm-c opened this issue Jan 22, 2020 · 7 comments
Closed

Updating the code the "normal" way #598

jm-c opened this issue Jan 22, 2020 · 7 comments
Labels
bug 🐞 Even a perfect program still has bugs

Comments

@jm-c
Copy link
Collaborator

jm-c commented Jan 22, 2020

Had an earlier clone, was on master branch, everything was in order as "git status"

nothing to commit, working tree clean

Then I updated my clone the usual way, just typing "git pull", but got plenty of warnings about
conflicts and so on. After that, "git status" reports:

On branch master
Your branch and 'origin/master' have diverged,
and have 1106 and 2212 different commits each, respectively.
(use "git pull" to merge the remote branch into yours)
You have unmerged paths.
(fix conflicts and run "git commit")
(use "git merge --abort" to abort the merge)

so it looks like I am far from a clean update.

My question: how to proceed when trying to update my Oceananigans local clone and
why the standard way does not work for this repos ?

@ali-ramadhan
Copy link
Member

Ah sorry this must be related to #509 where I rewrote git history using BFG Repo-Cleaner to remove some big JLD2 files that were accidentally pushed and blew up the size of the repository (500 MB+).

But after rewriting git history everyone has to delete their local version of the repository and git clone a fresh copy.

I think I cc'ed some people in the issue to warn them about this but didn't realize you still had an active copy, sorry about that!

@christophernhill
Copy link
Member

christophernhill commented Jan 22, 2020 via email

@ali-ramadhan
Copy link
Member

Ah sorry about that. Don't think we'll have to do it again as all the damage happens in the gh-pages branch which stores documentation, but will make sure to cc you guys on things like this.

@jm-c
Copy link
Collaborator Author

jm-c commented Jan 22, 2020

OK, thanks for the useful piece of information. Just for completeness, issue #509 was closed on Dec 09, 2019 and the 2 related PR #524 and PR #558 were merged in on Nov 03 and Dec 09, 2019 respectively.

@christophernhill
Copy link
Member

@ali-ramadhan would it be good to send messages to everyone who has a fork maybe and maybe keep an issue open, so people who have cloned can see? Of course it would also be good not to rewrite the history - that pretty much breaks how git works. In theory reviewing PRs should catch this?

@ali-ramadhan
Copy link
Member

@ali-ramadhan would it be good to send messages to everyone who has a fork maybe and maybe keep an issue open, so people who have cloned can see?

That's a good idea, I think the only other person who had an issue was @arcavaliere who had an open PR at the time, but otherwise we could tag all the forkers.

Of course it would also be good not to rewrite the history - that pretty much breaks how git works. In theory reviewing PRs should catch this?

Agreed. Yeah it took us a while to find the leak in #509 (JLD2 file wasn't added by us but by examples generating files when built) and the damage was contained to the gh-pages branch but the reason it affected the master branch was that I also deleted an old regression test file.

Now that we're more aware of this issue I think we can stop it from happening again.

@ali-ramadhan ali-ramadhan added the bug 🐞 Even a perfect program still has bugs label Feb 15, 2020
@ali-ramadhan
Copy link
Member

Guessing this isn't an issue anymore so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Even a perfect program still has bugs
Projects
None yet
Development

No branches or pull requests

3 participants