-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(0.88.0) MPI communication and computation overlap in the HydrostaticFreeSurfaceModel
and NonhydrostaticModel
#3125
Merged
Merged
Changes from all commits
Commits
Show all changes
576 commits
Select commit
Hold shift + click to select a range
eb6f5e6
comment
simone-silvestri 80fdc83
fixed tag problems
simone-silvestri 7cd4b44
bugfix
simone-silvestri 28c26bc
Merge branch 'main' into ss/load-balance-and-corners
simone-silvestri 9f3b273
resolve conflicts
navidcy d2ad49c
Update scalar_biharmonic_diffusivity.jl
simone-silvestri 165e15e
Update src/Distributed/multi_architectures.jl
simone-silvestri 88569a1
Update src/Distributed/partition_assemble.jl
simone-silvestri 89603f2
Update src/ImmersedBoundaries/ImmersedBoundaries.jl
simone-silvestri 10b37da
Update src/ImmersedBoundaries/active_cells_map.jl
simone-silvestri a24ef06
Merge branch 'main' into glw/catke-parameter-refactor
glwagner 3c68709
Update src/Distributed/interleave_comm_and_comp.jl
simone-silvestri 0206dd2
Merge branch 'glw/catke-parameter-refactor' of https://github.com/Cli…
glwagner 99d7f98
Clean up batched tridiagonal solver and vertically implicit solver
glwagner 287ac42
Fix bug in batched tridiagonal solver
glwagner 814cd43
bugfix
simone-silvestri 690d61c
Merge branch 'ss/load-balance-and-corners' of github.com:CliMA/Oceana…
simone-silvestri 4b6d8d6
Merge branch 'main' into ss/load-balance-and-corners
simone-silvestri 17e6fc0
Merge remote-tracking branch 'origin/main' into glw/catke-parameter-r…
glwagner df01667
Try to fix multi region immersed boundary issue
glwagner 3113880
Hopefully fix immersed boundary grid constructor
glwagner 389e243
Another fix
glwagner 5d6fac3
Merge branch 'main' into ss/load-balance-and-corners
navidcy 6492041
fixed project and manifest
simone-silvestri 5633d14
convert instead of FT
simone-silvestri 9f895bb
export KernelParameters
simone-silvestri 9842f6e
remove FT
simone-silvestri 126829c
removed useless where FT
simone-silvestri c5dc1ec
Merge remote-tracking branch 'origin/main' into ss/load-balance-and-c…
simone-silvestri 9569ac9
small bugfix
simone-silvestri 2917114
update manifest
simone-silvestri fa38abc
remove unbuffered communication
simone-silvestri 2cac349
little bit of a cleanup
simone-silvestri 8564df2
removed `views` comment
simone-silvestri a8c29e1
couple of bugfixes
simone-silvestri db8d996
fixed tests
simone-silvestri 6681636
probably done
simone-silvestri d1eb3ba
same thing for nonhydrostatic model
simone-silvestri f2406fb
include file
simone-silvestri 03ff7da
bugfix
simone-silvestri 23a0040
prepare for nonhydrostatic multiregion
simone-silvestri f2f5de3
also here
simone-silvestri 4e2b04b
bugfix
simone-silvestri b29a798
other bugfix
simone-silvestri f0b93e5
fix closures
simone-silvestri 80f07c7
bugfix
simone-silvestri 2f28cb0
simplify
simone-silvestri 4c8136b
2D leith requires 2 halos!
simone-silvestri b222f57
AMD and Smag require 1 halo!
simone-silvestri 752e6f0
wrong order
simone-silvestri e36931a
correct halo handling for diffusivities
simone-silvestri 527b240
correct Leith formulation + fixes
simone-silvestri 0f3a06a
`only_local_halos` kwarg in `fill_halo_regions!`
simone-silvestri 718e0f8
bugfix
simone-silvestri 2e33069
FT on GPU
simone-silvestri 4be413e
bugfix
simone-silvestri ce0628a
bugfix
simone-silvestri a8285af
last bugfix?
simone-silvestri 07f8d1d
removed all offsets from kernels + fixed all tests
simone-silvestri e5975db
fix `_compute!`
simone-silvestri d82d908
finished
simone-silvestri bd26e8c
fixed broken tests
simone-silvestri 04bd76a
fixed docs
simone-silvestri e640e2a
miscellaneous changes
simone-silvestri 5333609
bugfix
simone-silvestri aaf6f25
removed tests for vertical subdivision
simone-silvestri c6fcc90
test corner passing
simone-silvestri 66e7ef3
correction
simone-silvestri d53cba6
retry
simone-silvestri 59c7cd5
fixed all problems
simone-silvestri 9b1412d
Added a validation example
simone-silvestri 28f052e
fixed tests
simone-silvestri 4b6743a
try new test
simone-silvestri b167ad9
fill send buffers in the correct place
simone-silvestri a85999d
fixed comments
simone-silvestri 2e3fb94
define async
simone-silvestri 1b0f2a8
pass the grid
simone-silvestri 306655a
bugfix
simone-silvestri 4c737f3
fix show method
simone-silvestri fb0505d
RefValue for mpi_tag
simone-silvestri d37a781
comment
simone-silvestri f5d203b
Merge branch 'main' into ss/load-balance-and-corners
simone-silvestri bcd4d02
add catke preprint
navidcy 80d46de
remove warning; add ref to catke preprint
navidcy 00a5eba
some code cleanup
navidcy 04e603c
correct the example
simone-silvestri 5f96fdc
Merge branch 'ss/load-balance-and-corners' of github.com:CliMA/Oceana…
simone-silvestri 59ae073
Merge branch 'main' into glw/catke-parameter-refactor
navidcy c8944b7
Update src/TurbulenceClosures/vertically_implicit_diffusion_solver.jl
glwagner 603f50e
bugfix
simone-silvestri 2e06209
Refactor unit tests
glwagner 86c89fd
Merge branch 'glw/catke-parameter-refactor' of https://github.com/Cli…
glwagner c724537
Generalize regridding for lat-lon
glwagner 9b62341
Merge branch 'glw/catke-parameter-refactor' of https://github.com/Cli…
glwagner 9069bf4
bugfix
simone-silvestri 40e87b5
Add newline
glwagner 19bc3dd
small correction
simone-silvestri 54f273c
new tests
simone-silvestri 9e520be
bugfix
simone-silvestri 5755a3a
Merge remote-tracking branch 'origin/main' into glw/catke-parameter-r…
glwagner 85d44f7
bugfix
simone-silvestri fdc0aea
back for testing
simone-silvestri f8c73ff
back for testing
simone-silvestri 6885c88
update manifest
simone-silvestri 6955b92
more options
simone-silvestri 876e4e3
more
simone-silvestri 0105179
finished
simone-silvestri 3b79b9a
test hypothesis
simone-silvestri d6520aa
fixed bug - correct speed now
simone-silvestri 5dbf9aa
add space
simone-silvestri 70ac393
bugfix
simone-silvestri 7d03b63
test
simone-silvestri 056ff34
more info
simone-silvestri 2514130
removed left-right connected computation
simone-silvestri cea3240
bugfix
simone-silvestri c1b2049
remove info
simone-silvestri abea7ef
improve
simone-silvestri c6deb5e
typo
simone-silvestri 66965ff
bugfix
simone-silvestri 2e7354e
bugfix
simone-silvestri 403e74f
correct comments
simone-silvestri 6580a12
bugfix
simone-silvestri 923d1b2
bugfix prescribed velocities
simone-silvestri 511352d
fixes
simone-silvestri 30acce8
ok on mac
simone-silvestri 0e211d7
bugfix
simone-silvestri 242d590
bug fixed
simone-silvestri 6ea2af3
bugfixxed
simone-silvestri 67d27ca
new default
simone-silvestri 19618b1
bugfix
simone-silvestri 93593f8
Merge remote-tracking branch 'origin/ss/fix_split_explicit' into ss/l…
simone-silvestri 3bb5844
remove <<<<HEAD
simone-silvestri 972730a
bugfix PrescribedVelocityFields
simone-silvestri cc5af47
default in another PR
simone-silvestri 3644e30
bugfix
simone-silvestri 2f60434
flat grids only in Grids
simone-silvestri a50ebb8
last bugfix
simone-silvestri ebdbc22
bugfix
simone-silvestri 18eae2d
try partial cells
simone-silvestri 3b8f2d7
bugfix
simone-silvestri 7d97dec
bugfix
simone-silvestri d5b3978
Merge branch 'main' into glw/catke-parameter-refactor
glwagner dad1301
Update test_turbulence_closures.jl
glwagner c57d2c7
small fixes
simone-silvestri 14a32a1
rework IBG and MRG
simone-silvestri 43c83ea
Update src/TurbulenceClosures/vertically_implicit_diffusion_solver.jl
simone-silvestri 45bdebc
small bugfix
simone-silvestri efa1029
Merge branch 'glw/catke-parameter-refactor' of github.com:CliMA/Ocean…
simone-silvestri 7ff28da
remove multiregion ibg with arrays for the moment
simone-silvestri 9582465
bugfix
simone-silvestri 040c1bd
little cleaner
simone-silvestri fe5e413
fixed tests
simone-silvestri 2530c9e
Merge remote-tracking branch 'origin/main' into glw/catke-parameter-r…
simone-silvestri 19164ed
Merge remote-tracking branch 'origin/main' into ss/load-balance-and-c…
simone-silvestri cd66ed3
see what the error is
simone-silvestri cd93563
allow changing halos from checkpointer
simone-silvestri 2c7a633
test it
simone-silvestri 5310c55
finally fixed it
simone-silvestri ac408b5
better naming
simone-silvestri 746a014
bugfix
simone-silvestri a4aa696
bugfix
simone-silvestri 9f8c1bb
bugfix
simone-silvestri 11f01d8
bugfix
simone-silvestri 2c0a170
removed useless tendency
simone-silvestri 24c6815
small fix
simone-silvestri d19ab3c
dummy commit
simone-silvestri 0cbfff9
merge
simone-silvestri 7688452
fix active cell map
simone-silvestri 0e81f12
comment
simone-silvestri 7e4bf9a
bugfix
simone-silvestri 347367e
bugfix
simone-silvestri 2068462
removed useless tendency
simone-silvestri c972d07
maybe just keep it does not harm too much
simone-silvestri e01c38c
should have fixed it?
simone-silvestri 45fb9d5
let's go now
simone-silvestri 170dc90
done
simone-silvestri f0ac1da
bugfix
simone-silvestri c9a4ae6
no need for this
simone-silvestri bae6127
Merge remote-tracking branch 'origin/main' into ss/load-balance-and-c…
simone-silvestri 6fc688e
convert Δt in time stepping
simone-silvestri 234bd8e
maximum
simone-silvestri be4d885
Merge branch 'ss/load-balance-and-corners' of github.com:CliMA/Oceana…
simone-silvestri d6e338d
minimum substeps
simone-silvestri 2eae774
more flexibility
simone-silvestri d6455c1
Merge branch 'ss/load-balance-and-corners' of github.com:CliMA/Oceana…
simone-silvestri 04242b4
bugfix
simone-silvestri 2b00958
mutlidimensional
simone-silvestri ea8b2ba
Merge branch 'main' into ss/load-balance-and-corners
simone-silvestri 3202adb
fallback methods
simone-silvestri 34eae95
Merge branch 'ss/load-balance-and-corners' of github.com:CliMA/Oceana…
simone-silvestri 086b21e
test a thing
simone-silvestri 9e1728f
change
simone-silvestri f6f0f3e
chnage
simone-silvestri 7e61e0b
change
simone-silvestri ecb5664
change
simone-silvestri 38bc808
update
simone-silvestri 836d629
update
simone-silvestri 636abdb
new offsets + return to previous KA
simone-silvestri dad5ad9
bugfix
simone-silvestri 10b2e97
bugfixxed
simone-silvestri 25316a6
remove debugging
simone-silvestri 6d21230
going back
simone-silvestri 1dc301f
Merge remote-tracking branch 'origin/ss/mpi-with-catke' into ss/load-…
simone-silvestri bf5d06b
Merge remote-tracking branch 'origin/main' into ss/load-balance-and-c…
simone-silvestri f8de976
more robus partitioning
simone-silvestri 4824add
quite new
simone-silvestri 4416f37
bugfix
simone-silvestri 74ef9eb
updated Manifest
simone-silvestri 20b470c
build with 1.9.3
simone-silvestri 943458a
switch boundary_buffer to required_halo_size
simone-silvestri 13982e3
bugfix
simone-silvestri a5ff1bc
Update src/Models/HydrostaticFreeSurfaceModels/single_column_model_mo…
simone-silvestri 44cff40
Update src/Models/HydrostaticFreeSurfaceModels/update_hydrostatic_fre…
simone-silvestri df6967b
bugfix
simone-silvestri d62fa07
Merge branch 'ss/load-balance-and-corners' of github.com:CliMA/Oceana…
simone-silvestri 229e4aa
biharmonic requires 2 halos
simone-silvestri d354418
buggfix
simone-silvestri 30aefe5
compute_auxiliaries!
simone-silvestri b8e913f
bugfix
simone-silvestri 8c4ed66
fixed it
simone-silvestri 271aa86
little change
simone-silvestri 1db41bb
some changes
simone-silvestri f2bc008
bugfix
simone-silvestri 0911063
bugfix
simone-silvestri e6608a6
bugfixxed
simone-silvestri 38f2b87
another bugfix
simone-silvestri 4ed8333
Merge branch 'main' into ss/load-balance-and-corners
simone-silvestri 7da9b59
compute_diffusivities!
simone-silvestri dafa13c
required halo size
simone-silvestri 56892eb
all fixed
simone-silvestri bf927ae
shorten line
simone-silvestri bac7f4e
fix comment
simone-silvestri d48d1c9
remove abbreviation
simone-silvestri 3679421
remove unused functions
simone-silvestri 92739b0
better explanation of the MPI tag
simone-silvestri eab6dde
Update src/ImmersedBoundaries/active_cells_map.jl
simone-silvestri 3bbcdcd
Update src/Solvers/batched_tridiagonal_solver.jl
simone-silvestri 4259130
change name
simone-silvestri c118bf0
Merge branch 'ss/load-balance-and-corners' of github.com:CliMA/Oceana…
simone-silvestri d5e75a3
docstring
simone-silvestri 256de76
name change on rank
simone-silvestri 0bfeb97
interior active cells
simone-silvestri 1b96804
calculate -> compute
simone-silvestri 8f6fc68
fixed tests
simone-silvestri de64e92
do not compute momentum in prescribed velocities
simone-silvestri 58d92ec
DistributedComputations
simone-silvestri cab51e5
DistributedComputations part #2
simone-silvestri dfbc048
bugfix
simone-silvestri 55b9299
fixed the docs
simone-silvestri b51e681
Merge branch 'main' into ss/load-balance-and-corners
navidcy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the breaking changes? This PR seems to concern only MPI which doesn't really have user facing stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It changes a lot of the internals of the code so I think it is good to bump the version.
There are some API changes such as:
active_cells_map
kwarg forImmersedBoundaryGrid
boundary_buffer
for scalar diffusivitiesand one breaking change