-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix few bugs + improve docstring of SplitExplicitFreeSurface
#3131
Conversation
Might be better to contribute this to the broader user API overhaul in #3124 (won't this cause conflicts?) |
#3124 was merged! |
@simone-silvestri, what exactly is |
That's right. Maybe we could have a better name for that. |
Well I at least added a remark. |
Δy = minimum_ xspacing
bug + improve SplitExplicitFreeSurface
docstringSplitExplicitFreeSurface
Perhaps at Oceananigans.jl/src/Models/HydrostaticFreeSurfaceModels/split_explicit_free_surface.jl Line 280 in f273c54
we should use Int(floor(...)) to be tad more conservative.
|
probably |
bugs:
Δy = minimum_xspacing(grid)
Δt_max
was changed tomax_Δt
substeps
via cfl then we need to ensure it's an integer