Type stabilize offset_data

[wsmoses]

cc @christophernhill

[navidcy]

@wsmoses, can you write a small description in the first comment summarizing what this PR do or fixes?

[glwagner]

I think these minor changes allow / encourage the compiler to infer the output type of offset_data --- is that right? As far as I can tell it does not change the type that's outputted by offset_data. But I could be wrong.

Once we confirm the intent we can merge (it could make sense also to add a comment to the code so that this doesn't get reverted for some reason in the future). @wsmoses let us know if you'd like to tag a patch release as well.

[wsmoses]

@glwagner yes indeed, the intent is to allow the compiler to infer the return (and internals) of offset_data. It does not change the result or result types.

[glwagner]

Nice, let's merge ! Patch release or no? There will probably be a patch release before long anyways.

[navidcy]

We'll have a minor release soon with #3125, right? So no need to bother here with patch?

[navidcy]

@glwagner your comments implies you approve but you didn't formally approve. Is there something left to be done here?

[glwagner]

@glwagner your comments implies you approve but you didn't formally approve. Is there something left to be done here?

Nothing left. Merged.