Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.90.11) Tests for a distributed Immersed boundary grid + fix some on_architecture bugs #3487

Merged
merged 18 commits into from
Mar 12, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 50 additions & 44 deletions test/test_distributed_hydrostatic_model.jl
Original file line number Diff line number Diff line change
Expand Up @@ -78,49 +78,55 @@ Ny = 32

for arch in archs
@testset "Testing distributed solid body rotation" begin
grid = LatitudeLongitudeGrid(arch, size = (Nx, Ny, 1),
halo = (3, 3, 3),
latitude = (-80, 80),
longitude = (-160, 160),
z = (-1, 0),
radius = 1,
topology=(Bounded, Bounded, Bounded))

global_grid = reconstruct_global_grid(grid)

# "s" for "serial" computation
us, vs, ws, cs, ηs = solid_body_rotation_test(global_grid)

us = Array(interior(us))
vs = Array(interior(vs))
ws = Array(interior(ws))
cs = Array(interior(cs))
ηs = Array(interior(ηs))

@info " Testing distributed solid body rotation with architecture $arch"
u, v, w, c, η = solid_body_rotation_test(grid)

u = Array(interior(u))
v = Array(interior(v))
w = Array(interior(w))
c = Array(interior(c))
η = Array(interior(η))

cpu_arch = cpu_architecture(arch)

us = partition_global_array(cpu_arch, us, size(u))
vs = partition_global_array(cpu_arch, vs, size(v))
ws = partition_global_array(cpu_arch, ws, size(w))
cs = partition_global_array(cpu_arch, cs, size(c))
ηs = partition_global_array(cpu_arch, ηs, size(η))

atol = eps(eltype(grid))
rtol = sqrt(eps(eltype(grid)))

@test all(isapprox(u, us; atol, rtol))
@test all(isapprox(v, vs; atol, rtol))
@test all(isapprox(w, ws; atol, rtol))
@test all(isapprox(c, cs; atol, rtol))
@test all(isapprox(η, ηs; atol, rtol))
underlying_grid = LatitudeLongitudeGrid(arch, size = (Nx, Ny, 1),
halo = (3, 3, 3),
latitude = (-80, 80),
longitude = (-160, 160),
z = (-1, 0),
radius = 1,
topology=(Bounded, Bounded, Bounded))

bottom(λ, φ) = -30 < λ < 30 && -40 < φ < 20 ? 0 : - 1

immersed_grid = ImmersedBoundaryGrid(underlying_grid, GridFittedBottom(bottom); active_cells_map = true)

for grid in (underlying_grid, immersed_grid)
global_grid = reconstruct_global_grid(grid)

# "s" for "serial" computation
us, vs, ws, cs, ηs = solid_body_rotation_test(global_grid)

us = Array(interior(us))
vs = Array(interior(vs))
ws = Array(interior(ws))
cs = Array(interior(cs))
ηs = Array(interior(ηs))

@info " Testing distributed solid body rotation with architecture $arch on $(typeof(grid).name.wrapper)"
u, v, w, c, η = solid_body_rotation_test(grid)

u = Array(interior(u))
v = Array(interior(v))
w = Array(interior(w))
c = Array(interior(c))
η = Array(interior(η))

cpu_arch = cpu_architecture(arch)

us = partition_global_array(cpu_arch, us, size(u))
vs = partition_global_array(cpu_arch, vs, size(v))
ws = partition_global_array(cpu_arch, ws, size(w))
cs = partition_global_array(cpu_arch, cs, size(c))
ηs = partition_global_array(cpu_arch, ηs, size(η))

atol = eps(eltype(grid))
rtol = sqrt(eps(eltype(grid)))

@test all(isapprox(u, us; atol, rtol))
@test all(isapprox(v, vs; atol, rtol))
@test all(isapprox(w, ws; atol, rtol))
@test all(isapprox(c, cs; atol, rtol))
@test all(isapprox(η, ηs; atol, rtol))
navidcy marked this conversation as resolved.
Show resolved Hide resolved
end
end
end