Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading comment #3493

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Remove misleading comment #3493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bac83d
bugfix
simone-silvestri Mar 1, 2024
8f43b2a
remove comment
simone-silvestri Mar 4, 2024
e6cc40c
Merge branch 'main' into ss/remove-comment
simone-silvestri Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/Fields/field.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,15 +743,6 @@ end
function fill_halo_regions!(field::Field, args...; kwargs...)
reduced_dims = reduced_dimensions(field)

# To correctly fill the halo regions of fields with non-default indices, we'd have to
# offset indices in the fill halo regions kernels.
# For now we punt and don't support filling halo regions on windowed fields.
# Note that `FieldBoundaryConditions` _can_ filter boundary conditions in
# windowed directions:
#
# filtered_bcs = FieldBoundaryConditions(field.indices, field.boundary_conditions)
#
# which will be useful for implementing halo filling for windowed fields in the future.
fill_halo_regions!(field.data,
field.boundary_conditions,
field.indices,
Expand Down
2 changes: 1 addition & 1 deletion test/test_distributed_hydrostatic_model.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Ny = 32
for arch in archs
@testset "Testing distributed solid body rotation" begin
grid = LatitudeLongitudeGrid(arch, size = (Nx, Ny, 1),
halo = (3, 3, 3),
halo = (4, 4, 4),
latitude = (-80, 80),
longitude = (-160, 160),
z = (-1, 0),
Expand Down