Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File splitting in NetCDFOutputWriter when max_filesize is exceeded #3512

Merged
merged 19 commits into from
Mar 15, 2024
Merged

File splitting in NetCDFOutputWriter when max_filesize is exceeded #3512

merged 19 commits into from
Mar 15, 2024

Commits on Mar 13, 2024

  1. feat:add netcdf file splitting

    @josuemtzmo
    josuemtzmo committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0fd8b5f View commit details
    Browse the repository at this point in the history

  2. feat:add netcdf file splitting test

    @josuemtzmo
    josuemtzmo committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b3730c8 View commit details
    Browse the repository at this point in the history

  3. fix: solve issue with test

    @josuemtzmo
    josuemtzmo committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    221ab0e View commit details
    Browse the repository at this point in the history

  4. fix: solve issue with test

    @josuemtzmo
    josuemtzmo committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2c4afa6 View commit details
    Browse the repository at this point in the history

  5. fix: remove test_part files

    @josuemtzmo
    josuemtzmo committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    8c1edeb View commit details
    Browse the repository at this point in the history

  6. Update src/OutputWriters/netcdf_output_writer.jl 

    Co-authored-by: Navid C. Constantinou <[email protected]>
    @josuemtzmo @navidcy
    josuemtzmo and navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f6d786a View commit details
    Browse the repository at this point in the history

  7. Improve cod style to make it easier to read 

    Co-authored-by: Navid C. Constantinou <[email protected]>
    @josuemtzmo @navidcy
    josuemtzmo and navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    99e4131 View commit details
    Browse the repository at this point in the history

  8. Improve code style to make it easier to read 

    Co-authored-by: Navid C. Constantinou <[email protected]>
    @josuemtzmo @navidcy
    josuemtzmo and navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    831fcaa View commit details
    Browse the repository at this point in the history

  9. Improve code style to make it easier to read 

    Co-authored-by: Navid C. Constantinou <[email protected]>
    @josuemtzmo @navidcy
    josuemtzmo and navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3cf4187 View commit details
    Browse the repository at this point in the history

  10. Improve code style to make it easier to read 

    Co-authored-by: Navid C. Constantinou <[email protected]>
    @josuemtzmo @navidcy
    josuemtzmo and navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    afa1ff1 View commit details
    Browse the repository at this point in the history

  11. Update src/OutputWriters/netcdf_output_writer.jl 

    Co-authored-by: Navid C. Constantinou <[email protected]>
    @josuemtzmo @navidcy
    josuemtzmo and navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    41c56fe View commit details
    Browse the repository at this point in the history

  12. Update test/test_netcdf_output_writer.jl 

    Co-authored-by: Navid C. Constantinou <[email protected]>
    @josuemtzmo @navidcy
    josuemtzmo and navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f372b1c View commit details
    Browse the repository at this point in the history

  13. Update test/test_netcdf_output_writer.jl 

    Co-authored-by: Navid C. Constantinou <[email protected]>
    @josuemtzmo @navidcy
    josuemtzmo and navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ced3035 View commit details
    Browse the repository at this point in the history

  14. change previous -> part;

    @navidcy
    navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    15cb4cb View commit details
    Browse the repository at this point in the history

  15. add doc for part kwarg;

    @navidcy
    navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    afc1acb View commit details
    Browse the repository at this point in the history

  16. better line breaking

    @navidcy
    navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a3772a6 View commit details
    Browse the repository at this point in the history

  17. initialize_nc_file! returns modified schedule

    @navidcy
    navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6eb9b19 View commit details
    Browse the repository at this point in the history

  18. Add testing to ensure no extra file is created 

    Co-authored-by: Navid C. Constantinou <[email protected]>
    @josuemtzmo @navidcy
    josuemtzmo and navidcy committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f953de3 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'main' into jmm/netcdf-filesize-split

    @navidcy
    navidcy committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    cd63bc3 View commit details
    Browse the repository at this point in the history