Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize file splitting for output writers #3515
Generalize file splitting for output writers #3515
Changes from 5 commits
e06d78e
b1ad9b6
183e729
0f5fedb
9276ba6
6c6e07e
ab7fec6
2937dc1
4f9af7e
73a94ef
cd30f3e
2f0e4f6
09c4abb
db94858
14ce9a8
4804fc2
3a846e5
4c1db46
f9b082f
527ac31
78998bc
60de913
fc49fb7
d8233b0
28cc203
97fa9bb
71dab3a
4c1cb92
6c0e974
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
path
was used later on in the code, but it wasn't updated. Thus the code crashed while creating the file and when thewriter.filepath
changed but not thepath
. The easier fix was to replace all instances ofpath
by thewriter.filepath
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that's a good reason!