Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interpolation for fields on ImmersedBoundaryGrids #3524

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Add interpolation for fields on ImmersedBoundaryGrids #3524

merged 9 commits into from
Apr 2, 2024

Conversation

simone-silvestri
Copy link
Collaborator

No description provided.

glwagner
glwagner approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of this branch is "correct immersed", but to be clear there is nothing wrong with immersed interpolation right (this PR merely re-translates functions for ImmersedBoundaryGrid). Or is more needed here?

@simone-silvestri
Copy link
Collaborator Author

yep interpolation for immersed boundary fields does not currently work because of these missing functions

@navidcy
Copy link
Collaborator

navidcy commented Apr 1, 2024

merge?

@navidcy navidcy added the immersed boundaries 鉀帮笍 Less Ocean, more anigans label Apr 1, 2024
@navidcy navidcy merged commit c0222cd into main Apr 2, 2024
48 checks passed
@navidcy navidcy deleted the ss/correct-immersed branch April 2, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

Assignees
No one assigned
Labels
immersed boundaries 鉀帮笍 Less Ocean, more anigans
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simone-silvestri @navidcy @glwagner