Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show methods display information about the advection scheme(s) #3542

Merged
merged 5 commits into from
Apr 7, 2024

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Apr 6, 2024

Closes #3534.

After this PR:

julia> using Oceananigans

julia> model = NonhydrostaticModel(grid = RectilinearGrid(size=(2, 3, 4), extent=(1, 1, 1)))
NonhydrostaticModel{CPU, RectilinearGrid}(time = 0 seconds, iteration = 0)
├── grid: 2×3×4 RectilinearGrid{Float64, Periodic, Periodic, Bounded} on CPU with 3×3×3 halo
├── timestepper: QuasiAdamsBashforth2TimeStepper
├── advection scheme: Centered reconstruction order 2
├── tracers: ()
├── closure: Nothing
├── buoyancy: Nothing
└── coriolis: Nothing

julia> model = ShallowWaterModel(grid = RectilinearGrid(size = (4, 4), extent = (1, 1), topology=(Periodic, Bounded, Flat)), gravitational_acceleration = 1)
┌ Warning: The ShallowWaterModel is currently unvalidated, subject to change, and should not be used for scientific research without adequate validation.
└ @ Oceananigans.Models.ShallowWaterModels ~/Research/OC8.jl/src/Models/ShallowWaterModels/shallow_water_model.jl:129
ShallowWaterModel{typename(CPU), Float64}(time = 0 seconds, iteration = 0) 
├── grid: 4×4×1 RectilinearGrid{Float64, Periodic, Bounded, Flat} on CPU with 3×3×0 halo
├── timestepper: RungeKutta3TimeStepper
├── advection scheme: 
│   ├── momentum: Upwind Biased reconstruction order 5
│   └── mass: WENO reconstruction order 5
├── tracers: ()
└── coriolis: Nothing

@glwagner
Copy link
Member

glwagner commented Apr 6, 2024

That looks nice!

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the hydrostatic model already shows the advection scheme?

@navidcy
Copy link
Collaborator Author

navidcy commented Apr 6, 2024

I guess the hydrostatic model already shows the advection scheme?

#3504

@navidcy navidcy merged commit 02e44aa into main Apr 7, 2024
46 checks passed
@navidcy navidcy deleted the ncc/show-advection branch April 7, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show for models should display the advection scheme too
2 participants