Dirchlet and Neumann aliases for Value and Gradient boundary conditions #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
=======================================
Coverage 72.86% 72.86%
=======================================
Files 22 22
Lines 1157 1157
=======================================
Hits 843 843
Misses 314 314
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
=======================================
Coverage 72.86% 72.86%
=======================================
Files 22 22
Lines 1157 1157
=======================================
Hits 843 843
Misses 314 314
Continue to review full report at Codecov.
|
glwagner
reviewed
Aug 13, 2019
|
True... Feel free to merge. (I'm trying to not merge my own pull requests.) |
|
Seems like good practice. |
arcavaliere
pushed a commit
to arcavaliere/Oceananigans.jl
that referenced
this pull request
Nov 6, 2019
Dirchlet and Neumann aliases for Value and Gradient boundary conditions Former-commit-id: 4c98658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow I always find myself saying Dirchlet and Neumann in real-life so I'd like to use the names in the code.
Wish Value/Gradient was the accepted nomenclature...