Add four more parameters for shear turbulence in unstable stratification #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
added a commit
that referenced
this pull request
Jun 6, 2024
…xplicit TKE substepping (#3585) * Generalize definition of Ri * Non-negative Ri * Use quasi-conservative reconstruction of shear production and buoyancy flux * Add convective mixing length for momentum * Update minimum TKE * Major reorganizations to get CATKE time-stepping to work * Working on comparison * Some updates * Heroics to get things to wokrk * Update tke time stepping * Bit of cleanup * Figure out the right temporal stencil * Updated default convective buoyancy flux and delete ccc methods * Add back convective mixing length for ccc * Grr also add back stability function for ccc * Better error message when setting fails for field time series * Better notation for surface buoyancy flux; * Implement split-explicit time-stepping for CATKE * Optimize CATKE substepping a bit more * Performance enhancements * Add third method to CATKE comparison * Minor improvements * Clean up * Update * Move around some inbounds * Delete unused code * Clean up time stepping * Little things * Improve show and consistently use surface-ignoring reconstruction * Update definition of Ri and try a new stability funciton * Delete show * Queue up change to sheared convection * Update scale * Another tweak * Add four more parameters for shear turbulence in unstable stratification (#3600) * Add special negative Ri branch to the stability function * Update parameters * Improve show for CATKE * Skip test for tuples-with-CATKE for now * Try to fix checkpointing / regression test issues * Its a special test so we have to comment it out * New parameters * Fixing missing word * Address review comments * delete unused FT * Update Project.toml --------- Co-authored-by: Navid C. Constantinou <[email protected]>
glwagner
added a commit
that referenced
this pull request
Jun 20, 2024
…(take 2) (#3605) * Generalize definition of Ri * Non-negative Ri * Use quasi-conservative reconstruction of shear production and buoyancy flux * Add convective mixing length for momentum * Update minimum TKE * Major reorganizations to get CATKE time-stepping to work * Working on comparison * Some updates * Heroics to get things to wokrk * Update tke time stepping * Bit of cleanup * Figure out the right temporal stencil * Updated default convective buoyancy flux and delete ccc methods * Add back convective mixing length for ccc * Grr also add back stability function for ccc * Better error message when setting fails for field time series * Better notation for surface buoyancy flux; * Implement split-explicit time-stepping for CATKE * Optimize CATKE substepping a bit more * Performance enhancements * Add third method to CATKE comparison * Minor improvements * Clean up * Update * Move around some inbounds * Delete unused code * Clean up time stepping * Little things * Improve show and consistently use surface-ignoring reconstruction * Update definition of Ri and try a new stability funciton * Delete show * Queue up change to sheared convection * Update scale * Another tweak * Add four more parameters for shear turbulence in unstable stratification (#3600) * Add special negative Ri branch to the stability function * Update parameters * Improve show for CATKE * Skip test for tuples-with-CATKE for now * Try to fix checkpointing / regression test issues * Its a special test so we have to comment it out * Make room for TKEDissipationVerticalDiffusivity * Things are more or less wokring * Trying to get k-epsilon to work * Success? * Wow its working * Updates to permit ensembles of closures * Change TimeInterval to avoid roundoff error issue plus some cleanup * fix typo * Import fix * Potentially address overflow problem * Minor improvements * Bug fix for safety factor * Add a script to inspect stability functions * Make schedule work even with fake models * Fix tests for TimeInterval * Fix JLD2 output writer tests * Fix NetCDF writer test? * Rm reference to CATKEVerticalDiffusivities * fix typo Co-authored-by: Simone Silvestri <[email protected]> * Update src/TurbulenceClosures/turbulence_closure_implementations/TKEBasedVerticalDiffusivities/catke_vertical_diffusivity.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/TurbulenceClosures/turbulence_closure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_equations.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Restore convective adjustment notation * Address a few review comments * Get rid of background diffusivities * Update src/TurbulenceClosures/turbulence_closure_implementations/TKEBasedVerticalDiffusivities/tke_dissipation_vertical_diffusivity.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Fix docstring * Add reference * Better docstrings and comments --------- Co-authored-by: Navid C. Constantinou <[email protected]> Co-authored-by: Simone Silvestri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.