-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enzyme: try bump without tuple changes #3618
Conversation
test/test_enzyme.jl
Outdated
autodiff(Enzyme.Reverse, | ||
set_initial_condition!, | ||
Duplicated(model, dmodel), | ||
Active(1.0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some indendenting irregularities here and above
src/Utils/kernel_launching.jl
Outdated
include_right_boundaries = false, | ||
reduced_dimensions = (), | ||
location = nothing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the indenting here
seems simple enough, just a few cosmetic comments. Does |
Project.toml
Outdated
@@ -11,6 +11,7 @@ CubedSphere = "7445602f-e544-4518-8976-18f8e8ae6cdb" | |||
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a" | |||
Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7" | |||
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae" | |||
Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in [extras] if it is just a testdep
@navidcy @glwagner this should superceded all previous enzyme prs (including compatbwlper), which I've gone ahead and closed just now. Some non enzyme tests had a nondeterministic ci failure about a directory not being empty, but otherwise all pass (incl enzyme tests). Once landed we should add a lot more integration test cases like @jlk9 your flux boundary |
Requires EnzymeAD/Enzyme.jl#1485 to release, which itself requires JuliaRegistries/General#108556
Perhaps means we don't change the other varargs stuff, but we'll have to wait and see.