Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Base.axes(f::Field) type-inferable for windowed fields #3624

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Jun 18, 2024

Resolves #3621

@glwagner glwagner changed the title Make Base.axes(f::Field) type-inferrable for windowed fields type stable Make Base.axes(f::Field) type-inferrable for windowed fields Jun 18, 2024
@navidcy navidcy added the performance 🏍️ So we can get the wrong answer even faster label Jun 22, 2024
@navidcy
Copy link
Collaborator

navidcy commented Jun 22, 2024

@erin-atkinson could you confirm that this resolves #3621?

@erin-atkinson
Copy link

This does fix #3621

@navidcy
Copy link
Collaborator

navidcy commented Jun 27, 2024

@glwagner merge when tests pass?

@navidcy navidcy changed the title Make Base.axes(f::Field) type-inferrable for windowed fields Make Base.axes(f::Field) type-inferable for windowed fields Jun 27, 2024
@glwagner glwagner merged commit fbf05fb into main Jun 28, 2024
46 checks passed
@glwagner glwagner deleted the glw/type-stable-axes branch June 28, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance 🏍️ So we can get the wrong answer even faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Huge memory use of Average associated with compilation
3 participants