-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(0.91.4) Fix interpolations in off-diagonal components of strain-rate tensor #3648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is right
If people are okay with it, I'll merge as soon as tests pass and register a new patch version, since this is a bugfix. |
These tests aren't passing, and I have no clue why. The error is:
But I never changed anything related to that. Does anyone know what's going on? |
Stochastic CI variability? I restarted them... |
Okay finally tests passed! @navidcy I tried restarting the tests over and over (honestly more than 10 times over the past few days) and they always failed. I could only make them pass this morning when I restarted them one at a time. That is, starting one, and only restarting the next failed test when the previous one had fully run. So maybe the variability we see in tests has to do with different processes trying to access the same resources... ? |
What you observe about one at a time etc I have observed it other times but I can’t say for sure… |
Yes it is a race condition |
I think the interpolation here for the w-terms of the strain-rate tensor hasn't being correctly done. In particular it was assuming that
w
was aCenterField
.Can someone please double-check?