Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.91.4) Fix interpolations in off-diagonal components of strain-rate tensor #3648

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

tomchor
Copy link
Collaborator

@tomchor tomchor commented Jul 8, 2024

I think the interpolation here for the w-terms of the strain-rate tensor hasn't being correctly done. In particular it was assuming that w was a CenterField.

Can someone please double-check?

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is right

@tomchor
Copy link
Collaborator Author

tomchor commented Jul 9, 2024

If people are okay with it, I'll merge as soon as tests pass and register a new patch version, since this is a bugfix.

@glwagner glwagner changed the title Fix interpolations in off-diagonal components of strain-rate tensor (0.91.4) Fix interpolations in off-diagonal components of strain-rate tensor Jul 9, 2024
@tomchor
Copy link
Collaborator Author

tomchor commented Jul 10, 2024

These tests aren't passing, and I have no clue why. The error is:

ERROR: `Enzyme=7da242da-08ed-463a-9acd-ee780be4f1d9` depends on `ChainRulesCore=d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4`, but no such entry exists in the manifest.

But I never changed anything related to that. Does anyone know what's going on?

@navidcy
Copy link
Collaborator

navidcy commented Jul 11, 2024

Stochastic CI variability? I restarted them...

@navidcy navidcy added the bug 🐞 Even a perfect program still has bugs label Jul 11, 2024
@tomchor tomchor merged commit ee60596 into main Jul 11, 2024
46 checks passed
@navidcy navidcy deleted the tc/bugfix-strain-rate branch July 11, 2024 17:53
@tomchor
Copy link
Collaborator Author

tomchor commented Jul 11, 2024

Okay finally tests passed!

@navidcy I tried restarting the tests over and over (honestly more than 10 times over the past few days) and they always failed. I could only make them pass this morning when I restarted them one at a time. That is, starting one, and only restarting the next failed test when the previous one had fully run.

So maybe the variability we see in tests has to do with different processes trying to access the same resources... ?

@navidcy
Copy link
Collaborator

navidcy commented Jul 11, 2024

What you observe about one at a time etc I have observed it other times but I can’t say for sure…

@glwagner
Copy link
Member

Okay finally tests passed!

@navidcy I tried restarting the tests over and over (honestly more than 10 times over the past few days) and they always failed. I could only make them pass this morning when I restarted them one at a time. That is, starting one, and only restarting the next failed test when the previous one had fully run.

So maybe the variability we see in tests has to do with different processes trying to access the same resources... ?

Yes it is a race condition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Even a perfect program still has bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants