Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tolerance for tracer conservation test #400

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

ali-ramadhan
Copy link
Member

This test occasionally fails as I set the tolerance a little low.

@ali-ramadhan ali-ramadhan added the testing 🧪 Tests get priority in case of emergency evacuation label Sep 12, 2019
Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Word.

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   71.74%   71.74%           
=======================================
  Files          23       23           
  Lines        1412     1412           
=======================================
  Hits         1013     1013           
  Misses        399      399

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab61592...58b7c91. Read the comment docs.

@ali-ramadhan ali-ramadhan merged commit f77d3e6 into master Sep 13, 2019
@ali-ramadhan ali-ramadhan deleted the tracer-test-tol branch September 13, 2019 01:03
arcavaliere pushed a commit to arcavaliere/Oceananigans.jl that referenced this pull request Nov 6, 2019
Increase tolerance for tracer conservation test

Former-commit-id: f77d3e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants