Pre-documentation cleanup #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to refactor PlanetaryConstants anyways.
Only left behind a convinient constructor for Earth.
Also removes dim property which is kind of useless as it doesn't tell you which dimensions are flat.
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
+ Coverage 71.39% 73.17% +1.77%
==========================================
Files 23 23
Lines 1416 1368 -48
==========================================
- Hits 1011 1001 -10
+ Misses 405 367 -38
Continue to review full report at Codecov.
|
glwagner
approved these changes
Sep 14, 2019
| @@ -210,48 +210,12 @@ function start_next_file(model::Model, fw::JLD2OutputWriter) | |||
| end | |||
| end | |||
|
|
|||
| #### | |||
arcavaliere
pushed a commit
to arcavaliere/Oceananigans.jl
that referenced
this pull request
Nov 6, 2019
Pre-documentation cleanup Former-commit-id: dd122e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to write documentation and docstrings but some parts of the code were a little too messy to be documented easily, so I ended up doing some cleanup that seems to deserve its own PR.
I mainly renamed all the abstract types to have the
Abstractprefix (following the Julia style guide) and simplifiedLinearEquationOfState,PlanetaryConstants, andRegularCartesianGridwhere I removed properties that weren't being used or that were redundant/useless.Resolves #190 (because the constants in question have been removed)
Resolves #285