-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-documentation cleanup #406
Conversation
We're going to refactor PlanetaryConstants anyways.
Only left behind a convinient constructor for Earth.
Also removes dim property which is kind of useless as it doesn't tell you which dimensions are flat.
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
+ Coverage 71.39% 73.17% +1.77%
==========================================
Files 23 23
Lines 1416 1368 -48
==========================================
- Hits 1011 1001 -10
+ Misses 405 367 -38
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve.
@@ -210,48 +210,12 @@ function start_next_file(model::Model, fw::JLD2OutputWriter) | |||
end | |||
end | |||
|
|||
#### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😏
Pre-documentation cleanup Former-commit-id: dd122e9
Started to write documentation and docstrings but some parts of the code were a little too messy to be documented easily, so I ended up doing some cleanup that seems to deserve its own PR.
I mainly renamed all the abstract types to have the
Abstract
prefix (following the Julia style guide) and simplifiedLinearEquationOfState
,PlanetaryConstants
, andRegularCartesianGrid
where I removed properties that weren't being used or that were redundant/useless.Resolves #190 (because the constants in question have been removed)
Resolves #285