Simplify AbstractModel, fixes show for RegularCartesianGrid #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RegularCartesianGrid, simplifies cell_diffusion_timescale dispatch
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 72.98% 73.05% +0.07%
==========================================
Files 25 25
Lines 1403 1403
==========================================
+ Hits 1024 1025 +1
+ Misses 379 378 -1
Continue to review full report at Codecov.
|
ali-ramadhan
approved these changes
Sep 15, 2019
arcavaliere
pushed a commit
to arcavaliere/Oceananigans.jl
that referenced
this pull request
Nov 6, 2019
Simplify AbstractModel, fixes show for RegularCartesianGrid Former-commit-id: 496d705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for merger when approved, and tests pass.