Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example test #424

Merged
merged 3 commits into from
Sep 21, 2019
Merged

Fix example test #424

merged 3 commits into from
Sep 21, 2019

Conversation

ali-ramadhan
Copy link
Member

Cherry picked some commits from PR #381 to fix the example test.

One thing that's going to be annoying about testing example scripts is that they evaluate in global scope when including them, so it's going to be easy to get variable name conflicts...

Not sure how to get around this as we agreed not to use functions for examples.

@ali-ramadhan ali-ramadhan added bug 🐞 Even a perfect program still has bugs testing 🧪 Tests get priority in case of emergency evacuation labels Sep 20, 2019
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #424 into master will increase coverage by 3.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   74.89%   78.46%   +3.56%     
==========================================
  Files          25       25              
  Lines        1414     1416       +2     
==========================================
+ Hits         1059     1111      +52     
+ Misses        355      305      -50
Impacted Files Coverage Δ
src/poisson_solvers.jl 97.65% <0%> (-0.77%) ⬇️
src/boundary_conditions.jl 86.88% <0%> (+1.63%) ⬆️
src/utils.jl 85.57% <0%> (+12.76%) ⬆️
...rc/TurbulenceClosures/velocity_tracer_gradients.jl 86.23% <0%> (+16.51%) ⬆️
...ures/verstappen_anisotropic_minimum_dissipation.jl 100% <0%> (+38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a956ad4...f32e3f1. Read the comment docs.

@glwagner
Copy link
Member

Might be able to wrap each example in a module within the temporary modified script that we use to run the test.

@glwagner
Copy link
Member

glwagner commented Sep 21, 2019

Check out #425. Would be a good place to implement auto-moduling.

@glwagner glwagner merged commit 885e9a3 into master Sep 21, 2019
@glwagner glwagner deleted the fix-example-test branch September 21, 2019 09:55
arcavaliere pushed a commit to arcavaliere/Oceananigans.jl that referenced this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Even a perfect program still has bugs testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants