-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table of contents to README #435
Conversation
add table of contents
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
=========================================
- Coverage 78.46% 71.5% -6.97%
=========================================
Files 25 25
Lines 1416 1400 -16
=========================================
- Hits 1111 1001 -110
- Misses 305 399 +94
Continue to review full report at Codecov.
|
Hi @MohanSha thank you for this PR! Didn't know you could have a table of contents in the README. This should be useful especially as we add more stuff to the README. I just have a couple of suggestions:
|
Woops, sorry I closed the PR by mistake but reopened it. |
Hmmm, I also think the movie hyperlinks in the "Contents" should link to sections in the README instead of to YouTube directly. I guess that would be
instead of
|
- Changed table of contents to contents - Made contents top-level items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the revisions @MohanSha! Looks great!
Add table of contents to README Former-commit-id: eb7fb36
add table of contents