Purpose new README layout #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2019 11:44
|
The README layout should be here: https://github.com/kamontat/Oceananigans.jl/tree/patch-1 |
added 2 commits
October 2, 2019 11:50
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=========================================
- Coverage 72.07% 71.5% -0.58%
=========================================
Files 26 25 -1
Lines 1418 1400 -18
=========================================
- Hits 1022 1001 -21
- Misses 396 399 +3
Continue to review full report at Codecov.
|
ali-ramadhan
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Hey @kamontat thanks so much for improving the README! And sorry for the slow response on our part.
I think it looks really great, especially the fancy new badges!
I just resolved some merge conflicts so it should be ready to merge now.
@glwagner @suyashbire1 What do you guys think of the new look?
arcavaliere
pushed a commit
to arcavaliere/Oceananigans.jl
that referenced
this pull request
Nov 6, 2019
Purpose new README layout Former-commit-id: 141e291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.