Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use coverage job from earlier GitLab CI yaml #472

Merged
merged 2 commits into from
Oct 13, 2019

Conversation

ali-ramadhan
Copy link
Member

Not sure if this will fix the failing coverage job so I've also allows failures on coverage.

Coverage will be reported from v1.2

@ali-ramadhan ali-ramadhan added the testing 🧪 Tests get priority in case of emergency evacuation label Oct 12, 2019
@ali-ramadhan ali-ramadhan changed the title Use coverage job for earlier GitLab CI yaml Use coverage job from earlier GitLab CI yaml Oct 12, 2019
@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #472 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   71.65%   71.65%           
=======================================
  Files          26       26           
  Lines        1418     1418           
=======================================
  Hits         1016     1016           
  Misses        402      402

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17414b8...f6d89bd. Read the comment docs.

@ali-ramadhan
Copy link
Member Author

I'll merge this so we stop seeing red crosses everywhere, but coverage job is failing for some reason so the codecov badge in the README will be reporting the CPU-only code coverage until this is fixed.

@ali-ramadhan ali-ramadhan merged commit 289b1e3 into master Oct 13, 2019
@ali-ramadhan ali-ramadhan deleted the ar/fix-gitlab-coverage branch October 13, 2019 11:58
arcavaliere pushed a commit to arcavaliere/Oceananigans.jl that referenced this pull request Nov 6, 2019
Use coverage job from earlier GitLab CI yaml

Former-commit-id: 289b1e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants