Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests for models with LES closures (round 2) #484

Merged
merged 7 commits into from
Oct 17, 2019

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Oct 16, 2019

This PR picks up from where PR #479 left off. From #479:

This PR adds two regression tests for models that use the ConstantSmagorinsky closure and the AnisotropicMinimumDissipation closure. It also organizes the regression tests into a separate directory.

Resolves #473

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #484 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files          26       26           
  Lines        1418     1418           
=======================================
  Hits         1022     1022           
  Misses        396      396
Impacted Files Coverage Δ
src/Oceananigans.jl 62.5% <ø> (ø) ⬆️
src/models.jl 81.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141e291...8f61f0e. Read the comment docs.

@glwagner glwagner merged commit 99b1a70 into master Oct 17, 2019
@glwagner glwagner deleted the les-regression-test-round-2 branch October 17, 2019 03:57
arcavaliere pushed a commit to arcavaliere/Oceananigans.jl that referenced this pull request Nov 6, 2019
…-round-2

Regression tests for models with LES closures (round 2)

Former-commit-id: 99b1a70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LES regression test
2 participants