Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatiblity entries to Project.toml #492

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Conversation

ali-ramadhan
Copy link
Member

I've added [compat] entries in Project.toml which we need for automatic package registration: JuliaRegistries/General#4485

Someone please approve/merge.

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #492 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   73.34%   73.34%           
=======================================
  Files          27       27           
  Lines        1508     1508           
=======================================
  Hits         1106     1106           
  Misses        402      402

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5114a22...952d506. Read the comment docs.

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you determine all of these requirements? Are these strict requirements or guesses?

I don't understand the package manager too well, but I have run into some tricky issues with dependency-validity occasionally; will be good if this PR helps avoid that (and does not introduce new issues).

@ali-ramadhan
Copy link
Member Author

How did you determine all of these requirements? Are these strict requirements or guesses?

The CUDA packages and GPUifyLoops are strict requirements because we rely on recent features.

For the other packages I just used the version we currently have specified in Manifest.toml as we haven't had problems with the current environment (and tests pass). I assumed that future versions will be compatible to avoid having to constantly update upper bounds, but if a new version of a package introduces problems we can add upper bounds. I added ^1 for packages that may release a v1.0.

@ali-ramadhan ali-ramadhan merged commit 4962533 into master Oct 22, 2019
@ali-ramadhan ali-ramadhan deleted the ar/compat-entries branch October 22, 2019 14:29
arcavaliere pushed a commit to arcavaliere/Oceananigans.jl that referenced this pull request Nov 6, 2019
Add compatiblity entries to Project.toml

Former-commit-id: 4962533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants