Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate regression test data following reversal of k index #526

Merged
merged 7 commits into from
Nov 4, 2019

Conversation

ali-ramadhan
Copy link
Member

@ali-ramadhan ali-ramadhan commented Nov 4, 2019

Following the reversal of the k index (PR #462) we need to regenerate all regression test data to correspond to the new convention. This PR does that.

Had to update some of the tests as the output data format has changed (e.g. now has halos) and was originally generated a long time ago. I also increased code reuse among the regression tests for summarizing the result of each regression test.

This PR is part of #471

@ali-ramadhan ali-ramadhan added cleanup 🧹 Paying off technical debt testing 🧪 Tests get priority in case of emergency evacuation labels Nov 4, 2019
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #526   +/-   ##
======================================
  Coverage    62.6%   62.6%           
======================================
  Files          70      70           
  Lines        2054    2054           
======================================
  Hits         1286    1286           
  Misses        768     768

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3aa7a2...ae0dfb4. Read the comment docs.

@ali-ramadhan ali-ramadhan merged commit 2bb3201 into master Nov 4, 2019
@ali-ramadhan ali-ramadhan deleted the ar/regen-regression-date branch November 4, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants