Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically stretched Cartesian grid #543

Merged
merged 18 commits into from
Jan 14, 2020

Conversation

ali-ramadhan
Copy link
Member

@ali-ramadhan ali-ramadhan commented Dec 2, 2019

This PR adds a vertically stretched grid.

Resolves #47
Works towards #471
Resolves #531
Resolves #544

@ali-ramadhan ali-ramadhan added the feature 🌟 Something new and shiny label Dec 2, 2019
@ali-ramadhan ali-ramadhan changed the title Vertically stretched Cartesian grid [WIP] Vertically stretched Cartesian grid Dec 2, 2019
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #543 into master will increase coverage by 5.14%.
The diff coverage is 63.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   68.64%   73.79%   +5.14%     
==========================================
  Files          70       71       +1     
  Lines        1990     2049      +59     
==========================================
+ Hits         1366     1512     +146     
+ Misses        624      537      -87
Impacted Files Coverage Δ
src/Operators/derivative_operators.jl 90.62% <ø> (+32%) ⬆️
src/Operators/divergence_operators.jl 100% <ø> (ø) ⬆️
src/Operators/tracer_advection_operators.jl 100% <ø> (ø) ⬆️
...urbulenceClosures/viscous_dissipation_operators.jl 100% <ø> (ø) ⬆️
src/Solvers/Solvers.jl 100% <ø> (ø) ⬆️
src/Operators/laplacian_operators.jl 100% <ø> (+85.71%) ⬆️
src/OutputWriters/jld2_output_writer.jl 84.61% <ø> (ø) ⬆️
src/Operators/momentum_advection_operators.jl 100% <ø> (ø) ⬆️
src/Diagnostics/cfl.jl 66.66% <ø> (ø) ⬆️
src/Oceananigans.jl 75% <ø> (ø) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fbbc93...8e51fdc. Read the comment docs.

@ali-ramadhan ali-ramadhan changed the title [WIP] Vertically stretched Cartesian grid Vertically stretched Cartesian grid Jan 8, 2020
@ali-ramadhan
Copy link
Member Author

If we're okay with merging a vertically stretched grid abstraction by itself with some tests that ensure the vertical levels are correctly computed then I think this PR is ready to be reviewed.

Pressure solver and full integration will come in a future PR.

@ali-ramadhan ali-ramadhan merged commit 008e7c2 into master Jan 14, 2020
@ali-ramadhan ali-ramadhan deleted the ar/vertically-stretched-grid-v2 branch January 14, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🌟 Something new and shiny
Projects
None yet
1 participant