-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertically stretched Cartesian grid #543
Conversation
Also infer types in constructor.
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
+ Coverage 68.64% 73.79% +5.14%
==========================================
Files 70 71 +1
Lines 1990 2049 +59
==========================================
+ Hits 1366 1512 +146
+ Misses 624 537 -87
Continue to review full report at Codecov.
|
If we're okay with merging a vertically stretched grid abstraction by itself with some tests that ensure the vertical levels are correctly computed then I think this PR is ready to be reviewed. Pressure solver and full integration will come in a future PR. |
This PR adds a vertically stretched grid.
Resolves #47
Works towards #471
Resolves #531
Resolves #544