-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default Ω_Earth and R_Earth for FPlane and BetaPlane #550
Conversation
How many significant digits would we like to use? The number of digits in each constant is not consistent. |
I think we should use as many significant digits as possible up to experimental uncertainty. Why should different constants have the same number of significant digits, especially if they're not always combined? For For |
I guess that's a fair point. I don't think we use all the significant digits available from experiments for Right --- But if the values of such constants are super important to users simulations, its probably best to encourage them to set them explicitly in scripts. But, hardly matters at this point since all we do are rectangles... |
I think in these cases we should copy over all 42 digits.
True. If it turns out to be a bad idea to assume defaults then we can take them away. |
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
+ Coverage 67.72% 71.59% +3.86%
==========================================
Files 69 71 +2
Lines 1952 2341 +389
==========================================
+ Hits 1322 1676 +354
- Misses 630 665 +35
Continue to review full report at Codecov.
|
Resolves #510