Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banners like ##### instead of #### #551

Merged
merged 4 commits into from
Dec 10, 2019
Merged

Banners like ##### instead of #### #551

merged 4 commits into from
Dec 10, 2019

Conversation

ali-ramadhan
Copy link
Member

The pettiest of PRs but this was bothering me as I thought YASGuide used four # but it was actually five.

@ali-ramadhan ali-ramadhan added the cleanup 🧹 Paying off technical debt label Dec 4, 2019
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #551 into master will decrease coverage by 3.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   71.09%   67.72%   -3.37%     
==========================================
  Files          69       69              
  Lines        1958     1952       -6     
==========================================
- Hits         1392     1322      -70     
- Misses        566      630      +64
Impacted Files Coverage Δ
...urbulenceClosures/viscous_dissipation_operators.jl 100% <ø> (ø) ⬆️
src/Operators/derivative_operators.jl 58.62% <ø> (-32.01%) ⬇️
src/Operators/momentum_advection_operators.jl 100% <ø> (ø) ⬆️
src/Operators/tracer_advection_operators.jl 100% <ø> (ø) ⬆️
src/Operators/divergence_operators.jl 100% <ø> (ø) ⬆️
src/halo_regions.jl 86.11% <ø> (ø) ⬆️
src/TurbulenceClosures/diffusion_operators.jl 100% <ø> (ø) ⬆️
src/Operators/laplacian_operators.jl 14.28% <ø> (-85.72%) ⬇️
src/Operators/areas_and_volumes.jl 100% <ø> (ø) ⬆️
src/Operators/difference_operators.jl 65.21% <ø> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f34887...806536a. Read the comment docs.

@ali-ramadhan ali-ramadhan merged commit cdf5091 into master Dec 10, 2019
@ali-ramadhan ali-ramadhan deleted the ar/petty-##### branch December 10, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants