Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On CI servers select the GPU with the most memory #559

Merged
merged 4 commits into from
Dec 12, 2019

Conversation

ali-ramadhan
Copy link
Member

Thanks for the tip @maleadt!

@ali-ramadhan ali-ramadhan added the documentation 📜 The sacred scrolls label Dec 7, 2019
@ali-ramadhan ali-ramadhan added testing 🧪 Tests get priority in case of emergency evacuation and removed documentation 📜 The sacred scrolls labels Dec 7, 2019
@glwagner
Copy link
Member

glwagner commented Dec 9, 2019

@ali-ramadhan, the GitLab test is failing.

@ali-ramadhan
Copy link
Member Author

Hmmm, looks like it's failing the verification experiment tests but passes everything else...

336 Stratified Couette flow verification [CPU]: Error During Test at /builds/JuliaGPU/Oceananigans-jl/test/test_verification.jl:25
337   Test threw exception
338   Expression: run_stratified_couette_flow_verification(arch)
339   UndefVarError: simulate_stratified_couette_flow not defined
340   Stacktrace:
341    [1] run_stratified_couette_flow_verification(::CPU) at /builds/JuliaGPU/Oceananigans-jl/test/test_verification.jl:14
342    [2] top-level scope at /builds/JuliaGPU/Oceananigans-jl/test/test_verification.jl:25
343    [3] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Test/src/Test.jl:1083
344    [4] top-level scope at /builds/JuliaGPU/Oceananigans-jl/test/test_verification.jl:24
345    [5] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Test/src/Test.jl:1083
346    [6] top-level scope at /builds/JuliaGPU/Oceananigans-jl/test/test_verification.jl:20

Will look into it. Should be a simple fix.

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #559 into master will increase coverage by 3.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #559     +/-   ##
=========================================
+ Coverage   67.72%   71.43%   +3.7%     
=========================================
  Files          69       70      +1     
  Lines        1952     2307    +355     
=========================================
+ Hits         1322     1648    +326     
- Misses        630      659     +29
Impacted Files Coverage Δ
src/boundary_conditions.jl 69.06% <0%> (-4.97%) ⬇️
src/halo_regions.jl 83.05% <0%> (-3.07%) ⬇️
src/TimeSteppers/kernels.jl 57.8% <0%> (-2.6%) ⬇️
src/AbstractOperations/computations.jl 75.75% <0%> (-0.25%) ⬇️
src/Solvers/batched_tridiagonal_solver.jl 100% <0%> (ø)
src/OutputWriters/netcdf_output_writer.jl 89.23% <0%> (+2.69%) ⬆️
src/utils.jl 74.35% <0%> (+2.79%) ⬆️
src/TimeSteppers/TimeSteppers.jl 78.78% <0%> (+4.42%) ⬆️
src/Diagnostics/cfl.jl 71.42% <0%> (+4.76%) ⬆️
src/Operators/interpolation_operators.jl 64.28% <0%> (+4.76%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a511fdd...ef7fb60. Read the comment docs.

@ali-ramadhan
Copy link
Member Author

Fixed. Should be good to merge now.

@glwagner glwagner merged commit 0d0e50a into master Dec 12, 2019
@ali-ramadhan ali-ramadhan deleted the ar/pick-better-ci-gpu branch December 13, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants