Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeawaterBuoyancy with constant temperature or constant salinity #595

Merged
merged 7 commits into from
Jan 23, 2020

Conversation

glwagner
Copy link
Member

Resolves #581

…* salinity; eliminates buoyancy_frequency_squared in favor of dz_b function, modifications to depth function for nonlinear equations of state
@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #595 into master will decrease coverage by 2.56%.
The diff coverage is 66.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   77.03%   74.46%   -2.57%     
==========================================
  Files         125      121       -4     
  Lines        2155     2181      +26     
==========================================
- Hits         1660     1624      -36     
- Misses        495      557      +62
Impacted Files Coverage Δ
...lence_closure_implementations/smagorinsky_lilly.jl 92.85% <100%> (ø) ⬆️
...nce_closure_implementations/blasius_smagorinsky.jl 50% <100%> (ø) ⬆️
src/Buoyancy/linear_equation_of_state.jl 29.41% <33.33%> (-39.82%) ⬇️
src/Buoyancy/Buoyancy.jl 63.15% <61.11%> (-36.85%) ⬇️
src/Buoyancy/nonlinear_equation_of_state.jl 70.83% <70.83%> (-29.17%) ⬇️
src/Buoyancy/seawater_buoyancy.jl 70.58% <73.33%> (-12.75%) ⬇️
...ure_implementations/leith_enstrophy_diffusivity.jl 32.25% <0%> (-66.13%) ⬇️
src/Operators/interpolation_operators.jl 59.52% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f1f5a...801337b. Read the comment docs.

@glwagner glwagner merged commit ea74667 into master Jan 23, 2020
@glwagner glwagner deleted the single-component-equation-of-state branch January 23, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TemperatureBuoyancy for evolving temperature without salinity
2 participants