Fixes off-by-one indexing error in hydrostatic pressure integrat… #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ramadhan
approved these changes
Feb 3, 2020
|
@ali-ramadhan gitlab failed. Help. |
|
It just timed out which is quite common. I restarted it. If it times out again I'll just run the GPU tests manually on Tartarus. |
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
==========================================
+ Coverage 74.51% 74.55% +0.04%
==========================================
Files 117 117
Lines 2209 2209
==========================================
+ Hits 1646 1647 +1
+ Misses 563 562 -1
Continue to review full report at Codecov.
|
ali-ramadhan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error may not be consequential for any work we've done so far because it amounts to changing an irrelevant 'gauge condition' on the pressure in many cases.
It does impact set-ups with vertically stretched grids, and it may impact set-ups that specify a horizontal buoyancy gradient at the surface. None of the regression tests deal with such scenarios.