Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge famous people #613

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Purge famous people #613

merged 1 commit into from
Feb 4, 2020

Conversation

ali-ramadhan
Copy link
Member

This PR removes the Dirchlet and Neumann aliases for boundary condition types.

@ali-ramadhan ali-ramadhan added the cleanup 🧹 Paying off technical debt label Feb 3, 2020
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         117      117           
  Lines        2209     2209           
=======================================
  Hits         1647     1647           
  Misses        562      562
Impacted Files Coverage Δ
src/BoundaryConditions/BoundaryConditions.jl 100% <ø> (ø) ⬆️
src/Oceananigans.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f080635...e714993. Read the comment docs.

@ali-ramadhan ali-ramadhan merged commit f924f34 into master Feb 4, 2020
@ali-ramadhan ali-ramadhan deleted the ar/rm-aliases branch February 4, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants