-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Julia 1.3 the new minimum required version #636
Conversation
Hmmm, yeah so the GitLab CI GPU tests always get stuck testing the pressure solvers (which is where we start creating FFT plans) with Julia 1.3+. Was never able to reproduce this on any machine I have access to. Example build logs: @maleadt Was wondering if you have any ideas about what's going on? Maybe someone else had similiar issues. I'll isolate exactly which test/line it always gets stuck on. |
Worth noting that Travis tests are much faster now! 🎉 |
I've seen some people having issues which turned out FFT threading related, not sure if that applies here. If a job is stuck, ping me on Slack and I'll have a look at dumping a backtrace using gdb, |
OK, so this is the same issue as @navidcy experienced with FourierFlows.jl -- did you get this resolved? Looks to be happening on 1.3+. Backtrace from GDB:
From
Other tasks seems to be waiting for that to finish:
So this looks FFTW related, but rings no bells here. Maybe @stevengj has seen this before? |
Thanks for looking into this @maleadt! Hmmm, if it's indeed a multithreading issue then maybe the simple solution is to just turn off multithreading for FFTW during testing? |
I haven't seen that before… not sure why there would be a deadlock, but you can try setting JULIA_NUM_THREADS=1 as a workaround. |
Not sure if JuliaMath/FFTW.jl#138 will help? |
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 70.7% 77.99% +7.29%
==========================================
Files 118 118
Lines 2270 2345 +75
==========================================
+ Hits 1605 1829 +224
+ Misses 665 516 -149
Continue to review full report at Codecov.
|
Thanks so much for looking into this @stevengj! I tried both suggestions.
We don't compute any large FFTs during testing so |
Would be nice to get this into v0.23.0
Resolves #625